remove redundunt check in static_file() #1300
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oz123
reviewed
Jan 3, 2021
| @@ -2883,7 +2883,7 @@ def static_file(filename, root, | |||
|
|
|||
| if not filename.startswith(root): | |||
| return HTTPError(403, "Access denied.") | |||
| if not os.path.exists(filename) or not os.path.isfile(filename): | |||
| if not os.path.isfile(filename): | |||
There was a problem hiding this comment.
Indeed, this is redundant.
In [71]: os.path.isfile("no-such-file")
Out[71]: False
@SergBobrovsky I believe that it will be easier for @defnull to review all your PRs if your commit messages are a bit more verbose.
Adding stuff like this in the commit message surely helps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.