-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build/docker): #88
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
14f4477
wip
spg 8ca8ce2
wip
spg 568e5ae
secret param
spg 0a7c6e0
move to inputs section
spg 744071e
try fix names
spg 713fb9a
fix pipe
spg 90c91f7
try removing ghcr
spg 09c9c86
Revert "try removing ghcr"
spg 9f9386b
add cache prefix
spg 21e8022
try removing ghcr image
spg 40bfed4
try removing ghcr
spg e39c2dc
use credentials v3
spg 1460046
mask password
spg a3165a6
remove repo-token
spg 3c52cf1
format
spg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -50,13 +50,15 @@ runs: | |
with: | ||
driver-opts: ${{ inputs.driver-opts }} | ||
buildkitd-flags: ${{ inputs.buildkitd-flags }} | ||
- uses: aws-actions/configure-aws-credentials@v1 | ||
- uses: aws-actions/configure-aws-credentials@v3 | ||
with: | ||
role-session-name: container_pusher | ||
role-to-assume: ${{ inputs.aws-role }} | ||
aws-region: ${{ inputs.aws-region }} | ||
- uses: aws-actions/amazon-ecr-login@v1 | ||
id: ecr | ||
with: | ||
mask-password: true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This removes a warning about displaying credentials in clear |
||
- uses: docker/metadata-action@v4 | ||
id: meta | ||
with: | ||
|
@@ -79,16 +81,14 @@ runs: | |
# The cache is using an experimental feature from Github | ||
# If there is any issues see the follow link | ||
# https://github.com/docker/build-push-action/blob/master/docs/advanced/cache.md | ||
- uses: docker/build-push-action@v3 | ||
env: | ||
DOCKER_BUILDKIT: '1' | ||
- uses: docker/build-push-action@v4 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Buildkit is enabled by default, so no need for |
||
with: | ||
context: ${{ inputs.context }} | ||
build-args: ${{ inputs.build-args }} | ||
file: ${{ inputs.dockerfile }} | ||
push: ${{ inputs.push }} | ||
cache-from: type=gha | ||
cache-to: type=gha,mode=max | ||
cache-from: type=registry,ref=${{ steps.ecr.outputs.registry }}/${{ inputs.repository }}:cache-${{ hashFiles(inputs.dockerfile) }} | ||
cache-to: type=registry,ref=${{ steps.ecr.outputs.registry }}/${{ inputs.repository }}:cache-${{ hashFiles(inputs.dockerfile) }},mode=max,image-manifest=true | ||
tags: ${{ steps.meta.outputs.tags }} | ||
labels: ${{ steps.meta.outputs.labels }} | ||
network: ${{ inputs.network }} | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This upgrade eliminates a warning regarding an outdated NodeJS version