Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build/docker): #88

Merged
merged 15 commits into from
Aug 31, 2023
12 changes: 6 additions & 6 deletions build/docker/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,15 @@ runs:
with:
driver-opts: ${{ inputs.driver-opts }}
buildkitd-flags: ${{ inputs.buildkitd-flags }}
- uses: aws-actions/configure-aws-credentials@v1
- uses: aws-actions/configure-aws-credentials@v3
Copy link
Author

@spg spg Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This upgrade eliminates a warning regarding an outdated NodeJS version

with:
role-session-name: container_pusher
role-to-assume: ${{ inputs.aws-role }}
aws-region: ${{ inputs.aws-region }}
- uses: aws-actions/amazon-ecr-login@v1
id: ecr
with:
mask-password: true
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes a warning about displaying credentials in clear

- uses: docker/metadata-action@v4
id: meta
with:
Expand All @@ -79,16 +81,14 @@ runs:
# The cache is using an experimental feature from Github
# If there is any issues see the follow link
# https://github.com/docker/build-push-action/blob/master/docs/advanced/cache.md
- uses: docker/build-push-action@v3
env:
DOCKER_BUILDKIT: '1'
- uses: docker/build-push-action@v4
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buildkit is enabled by default, so no need for DOCKER_BUILDKIT: '1'

with:
context: ${{ inputs.context }}
build-args: ${{ inputs.build-args }}
file: ${{ inputs.dockerfile }}
push: ${{ inputs.push }}
cache-from: type=gha
cache-to: type=gha,mode=max
cache-from: type=registry,ref=${{ steps.ecr.outputs.registry }}/${{ inputs.repository }}:cache-${{ hashFiles(inputs.dockerfile) }}
cache-to: type=registry,ref=${{ steps.ecr.outputs.registry }}/${{ inputs.repository }}:cache-${{ hashFiles(inputs.dockerfile) }},mode=max,image-manifest=true
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
network: ${{ inputs.network }}
Expand Down
Loading