This change fixes region redirect issues for opt-in regions #3303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3303 +/- ##
========================================
Coverage 93.18% 93.19%
========================================
Files 66 66
Lines 14345 14376 +31
========================================
+ Hits 13367 13397 +30
- Misses 978 979 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
SamRemis
requested changes
Nov 18, 2024
…legalLocationConstraintException error during region-redirect
SamRemis
reviewed
Nov 19, 2024
SamRemis
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When accessing an S3 bucket from the wrong region for opt-in regions, a 400
IllegalLocationConstraintExceptionerror is thrown. Botocore already has a functionality to automatically redirect requests to the correct region. This fix adds an additional condition to ensure that redirection happens whenever a request is made to the wrong region from opt-in regions.