Add support for stringArray and operationContextParams #3301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3301 +/- ##
===========================================
- Coverage 93.19% 93.18% -0.01%
===========================================
Files 66 66
Lines 14376 14412 +36
===========================================
+ Hits 13397 13430 +33
- Misses 979 982 +3 ☔ View full report in Codecov by Sentry. |
alexgromero
force-pushed
the
add-string-array-context-param
branch
from
b8f4f0d to
85adf28
Compare
alexgromero
changed the title
jonathan343
requested changes
Dec 3, 2024
Comment on lines
4
to
6
| "ResourceList": { | ||
| "type": "stringArray" | ||
| } |
There was a problem hiding this comment.
Related to my pervious comment: We should included tests for string array parameters that define default values.
aws-sdk-python-automation
added a commit
that referenced
this pull request
Dec 9, 2024
* release-1.35.77: Bumping version to 1.35.77 Update endpoints model Update to latest models Bump aws-actions/stale-issue-cleanup Bump codecov/codecov-action from 5.0.2 to 5.1.1 Add support for stringArray and operationContextParams (#3301)
hswong3i
pushed a commit
to alvistack/boto-botocore
that referenced
this pull request
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for the
stringArraytype parameter and the newoperationContextParamstrait.stringArrayParameters: Adds thestringArraytype, which allows a list of UTF-8 encoded strings.operationContextParamsTrait: Introduces theoperationContextParamstrait, which defines context parameters that must be bound to values using a limited subset of JMESPath expressions. This trait targets an operation shape.lru_cache_weakref: Adds the ability to take lists as input to lru_cache_weakref. All inputs to a cache must be immutable, so this change is necessary to support cachingstringArraytypes. Any future lists will need to be similarly cast to a tuple to take advantage of the cache, so this centralizes the logic.