Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event stream regression #3285

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Fix event stream regression #3285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changes/next-release/bugfix-s3-44124.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"type": "bugfix",
"category": "``s3``",
"description": "Fixed SelectObjectContent regression from `#3284 <https://github.com/boto/botocore/issues/3284>`__."
}
6 changes: 5 additions & 1 deletion botocore/handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1245,7 +1245,11 @@ def document_expires_shape(section, event_name, **kwargs):
def _handle_200_error(operation_model, response_dict, **kwargs):
# S3 can return a 200 response with an error embedded in the body.
# Convert the 200 to a 500 for retry resolution in ``_update_status_code``.
if not response_dict or operation_model.has_streaming_output:
if (
not response_dict
or operation_model.has_streaming_output
or operation_model.has_event_stream_output
):
# Operations with streaming response blobs are excluded as they
# can't be reliably distinguished from an S3 error.
return
Expand Down
Loading