Botocore imagebuilder paginators #2019
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add paginators for all list operations
|
Not sure why this is failing the ci/cd tests need help triaging this. |
|
This is resolves botocore issue #2017 |
|
@crashdummymch - Thank you for the PR. Have you had any chance to look at the failing tests ? For the |
|
I had not as I needed a little help trying to decifer the logs to determine
what the issue was. I will look to see if I can get this to pass with the
help you provided thanks
…On Tue, Aug 11, 2020, 16:28 swetashre ***@***.***> wrote:
@crashdummymch <https://github.com/crashdummymch> - Thank you for the PR.
Have you had any chance to look at the failing tests ? For the
ListComponents api the result_key is incorrect. Can you please correct it
? Please run the tests first locally to make sure its passing all the
tests. You can see which file is failing for this code in the travis logs.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2019 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAO7TKXYNHX7H4OAUVDYHLLSAGSVNANCNFSM4MH4BKKA>
.
|
github-actions
bot
removed
the
response-requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested and verified paginators work with this fix.