Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing pagination definitions for CloudWatch Events #1595

Merged
merged 1 commit into from
Dec 18, 2018

Conversation

slai
Copy link
Contributor

@slai slai commented Oct 31, 2018

There are currently no pagination definitions for CloudWatch Events APIs.

I've created them from the API Reference for this PR. The list of definitions now matches the API reference and also the list missing in #1462.

client = boto3.client('events', region_name='eu-west-1')

paginator = client.get_paginator('list_rules')
page_iterator = paginator.paginate(NamePrefix='RDS', PaginationConfig={'PageSize': 2})

for page in page_iterator:
    print(page)

There are currently no pagination definitions for CloudWatch Events APIs.

I've created them from the API Reference for this PR. The list of definitions now matches the API reference and also the list missing in boto#1462.

```python
client = boto3.client('events', region_name='eu-west-1')

paginator = client.get_paginator('list_rules')
page_iterator = paginator.paginate(NamePrefix='RDS', PaginationConfig={'PageSize': 2})

for page in page_iterator:
    print(page)
```
@codecov-io
Copy link

codecov-io commented Oct 31, 2018

Codecov Report

Merging #1595 into develop will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1595      +/-   ##
===========================================
- Coverage       92%   91.97%   -0.04%     
===========================================
  Files           50       50              
  Lines         9110     9110              
===========================================
- Hits          8382     8379       -3     
- Misses         728      731       +3
Impacted Files Coverage Δ
botocore/credentials.py 98.4% <0%> (-0.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6ed18b...9dbb2c2. Read the comment docs.

Copy link
Contributor

@kyleknap kyleknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slai Thanks for the PR! Looks good to me. Merging.

@kyleknap kyleknap merged commit 37d4b70 into boto:develop Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants