Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing paginator definitions for CloudFormation #1594

Closed
wants to merge 2 commits into from

Conversation

slai
Copy link
Contributor

@slai slai commented Oct 31, 2018

This adds the missing pagination definitions for the CloudFormation APIs, as described in #1462.

I've tested DescribeChangeSet and ListChangeSets and both work as expected after this change,

client = boto3.client('cloudformation', region_name='eu-west-1')

paginator = client.get_paginator('list_change_sets')
page_iterator = paginator.paginate(StackName='MyStack')

for page in page_iterator:
    print(page)

This adds the missing pagination definitions for the CloudFormation APIs, as described in boto#1462.

I've tested DescribeChangeSet and ListChangeSets and both work as expected after this change,

```
client = boto3.client('cloudformation', region_name='eu-west-1')

paginator = client.get_paginator('list_change_sets')
page_iterator = paginator.paginate(StackName='MyStack')

for page in page_iterator:
    print(page)
```
@codecov-io
Copy link

codecov-io commented Oct 31, 2018

Codecov Report

Merging #1594 into develop will increase coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1594      +/-   ##
===========================================
+ Coverage       92%   92.24%   +0.23%     
===========================================
  Files           50       52       +2     
  Lines         9110     9592     +482     
===========================================
+ Hits          8382     8848     +466     
- Misses         728      744      +16
Impacted Files Coverage Δ
botocore/session.py 98.07% <0%> (-0.99%) ⬇️
botocore/exceptions.py 99.39% <0%> (-0.61%) ⬇️
botocore/utils.py 97.62% <0%> (-0.3%) ⬇️
botocore/handlers.py 97.04% <0%> (-0.1%) ⬇️
botocore/config.py 100% <0%> (ø) ⬆️
botocore/serialize.py 100% <0%> (ø) ⬆️
botocore/args.py 100% <0%> (ø) ⬆️
botocore/configprovider.py 93.45% <0%> (ø)
botocore/monitoring.py 99.51% <0%> (ø)
botocore/client.py 99.75% <0%> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6ed18b...53168cc. Read the comment docs.

@joguSD
Copy link
Contributor

joguSD commented Dec 19, 2018

All of these look good except for DescribeChangeSet. That operation has quite a few fields in the output in addition to the Changes result_key. I'm pretty sure they could all be added as non_aggregate_keys, but a couple of them are lists which is making me a little hesitant right now. I'd need to first confirm that the auxiliary lists are also not paginated, which I don't know off hand.

We would need to ensure that all output keys are accounted for, otherwise they'll be dropped from build_full_results output, which in turn effects the CLI in a backwards incompatible way.

@joguSD
Copy link
Contributor

joguSD commented Feb 19, 2019

Merged in 3b2a60b

@joguSD joguSD closed this Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants