Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudWatchLogs get_log_events should have paginator #1474

Closed
thehesiod opened this issue Jun 5, 2018 · 6 comments
Closed

CloudWatchLogs get_log_events should have paginator #1474

thehesiod opened this issue Jun 5, 2018 · 6 comments
Assignees
Labels
feature-request This issue requests a feature. p2 This is a standard priority issue paginator

Comments

@thehesiod
Copy link

given it returns pages of results and has a nextToken

@kyleknap
Copy link
Contributor

kyleknap commented Jun 6, 2018

I think it makes sense to have a paginator for this one. The only reason we do not is that it cannot be supported in our current pagination model schema. There is more context here: #613, but essentially we need context in which way we want to consume pagination tokens base on the startFromHead parameter and our pagination models do not support that. This may require either an update to our pagination model schema or a one off customization. Marking as enhancement.

@kyleknap kyleknap added enhancement This issue requests an improvement to a current feature. feature-request This issue requests a feature. and removed enhancement This issue requests an improvement to a current feature. labels Jun 6, 2018
@thehesiod
Copy link
Author

would a v2 of the API help?

@kyleknap
Copy link
Contributor

kyleknap commented Jun 6, 2018

That could help, but would have to be driven from the service team. I think the best/most immediate option would be to update our pagination specification to support this use case or do the one-off customization as that is more in the library's control.

@copumpkin
Copy link
Contributor

IMO it would be great to have two paginators for this API, one going forwards and the other backwards. If the model gets adapted to support the unusual API, it would be nice if it could support backwards pagination too.

I also think it's unusual enough to be worth just allowing individual service-specific custom paginators, and not revamping the broader model.

@PatMyron
Copy link

related: #1462

@tim-finnigan
Copy link
Contributor

These are the current paginators available for CloudWatchLogs: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/logs.html#paginators.

As mentioned in #1462 (comment), service teams now own their respective paginator model definitions since they are shared across SDKs. I created a new issue for tracking this specific feature request here in our cross-SDK repository: aws/aws-sdk#422. I also reached out to the CloudWatch Logs team to see if this is something that they can implement. Please refer to that new issue for updates going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request This issue requests a feature. p2 This is a standard priority issue paginator
Projects
None yet
Development

No branches or pull requests

6 participants