fix testing issue; Assert actual checksum values in tests.

boto · Nov 22, 2024 · 509440a · 509440a
1 parent 503ead6
commit 509440a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/botocore/httpchecksum.py b/botocore/httpchecksum.py
@@ -299,10 +299,11 @@ def resolve_request_checksum_algorithm(
         algorithm_member_header = _get_request_algorithm_member_header(
             operation_model, request, algorithm_member
         )
-        checksum_context["request_algorithm_header"] = {
-            "name": algorithm_member_header,
-            "value": DEFAULT_CHECKSUM_ALGORITHM,
-        }
+        if algorithm_member_header is not None:
+            checksum_context["request_algorithm_header"] = {
+                "name": algorithm_member_header,
+                "value": DEFAULT_CHECKSUM_ALGORITHM,
+            }
     else:
         return
 

diff --git a/tests/functional/test_s3.py b/tests/functional/test_s3.py
@@ -1534,7 +1534,7 @@ def test_trailing_checksum_set(self):
             b"STREAMING-UNSIGNED-PAYLOAD-TRAILER",
         )
         body = self.http_stubber.requests[0].body.read()
-        self.assertIn(b"x-amz-checksum-crc32", body)
+        self.assertIn(b"x-amz-checksum-crc32:eCQEmA==", body)
 
     def test_trailing_checksum_set_empty_body(self):
         with self.http_stubber:
@@ -1551,7 +1551,7 @@ def test_trailing_checksum_set_empty_body(self):
             b"STREAMING-UNSIGNED-PAYLOAD-TRAILER",
         )
         body = self.http_stubber.requests[0].body.read()
-        self.assertIn(b"x-amz-checksum-crc32", body)
+        self.assertIn(b"x-amz-checksum-crc32:AAAAAA==", body)
 
     def test_trailing_checksum_set_empty_file(self):
         with self.http_stubber:
@@ -1570,7 +1570,7 @@ def test_trailing_checksum_set_empty_file(self):
             sent_headers["x-amz-content-sha256"],
             b"STREAMING-UNSIGNED-PAYLOAD-TRAILER",
         )
-        self.assertIn(b"x-amz-checksum-crc32", body)
+        self.assertIn(b"x-amz-checksum-crc32:AAAAAA==", body)
 
     def test_content_sha256_not_set_if_config_value_is_true(self):
         # By default, put_object() provides a trailing checksum and includes the