Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added container credential provider to the credential precedence documentation #4338

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

RyanFitzSimmonsAK
Copy link
Contributor

@RyanFitzSimmonsAK RyanFitzSimmonsAK commented Nov 8, 2024

This PR adds the ECS container credential provider to the credential precedence, and adds a description (copied from the AWS CLI docs) of that provider.

@jonathan343
Copy link
Contributor

LGTM. I build the docs locally and confirmed this renders as expected:
Screenshot 2024-11-08 at 3 16 32 PM

@@ -287,6 +288,11 @@ Boto3 will attempt to load credentials from the Boto2 config file. It first chec
This credential provider is primarily for backwards compatibility purposes with Boto2.


Container credential provider
---------
You can associate an IAM role with each of your Amazon Elastic Container Service (Amazon ECS) task definitions. Temporary credentials for that role are then available to that task's containers. For more information, see `IAM Roles for Tasks <https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task-iam-roles.html>`_ in the Amazon Elastic Container Service Developer Guide.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably link to this page instead. It has the relevant information to the SDKs and the full scope of this provider, ECS (and IAM Roles for Tasks) is only one aspect of this feature.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rewrote the description to reflect this

@nateprewitt nateprewitt merged commit eb80fa1 into boto:develop Nov 22, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants