Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if composer install was successful #7

Closed
mpociot opened this issue Oct 2, 2017 · 1 comment
Closed

Check if composer install was successful #7

mpociot opened this issue Oct 2, 2017 · 1 comment

Comments

@mpociot
Copy link
Member

mpociot commented Oct 2, 2017

When installing a BotMan driver using the artisan command, we need to check if an error occurs and tell the user.
Right now we're always showing a success message.

https://github.com/botman/studio-addons/blob/master/src/Console/Commands/BotManInstallDriver.php#L78

thormeier added a commit to thormeier/studio-addons that referenced this issue Oct 2, 2017
@thormeier
Copy link

Changed run() to mustRun() according to https://symfony.com/doc/current/components/process.html. Also added symfony/process as dependency to have correct typehinting when checking out the project standalone, but if that dependency doesn't make any sense, I could remove that. :)

@mpociot mpociot closed this as completed Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants