Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerize project #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Dockerize project #11

wants to merge 1 commit into from

Conversation

yozel
Copy link

@yozel yozel commented Feb 22, 2019

I have just dockerized the project. It's running on my server right now.

PS, I created the same pull request (#10) before but it was closed automatically because of a history rewrite.

@mildsunrise
Copy link
Member

Thanks for the PR! But I'm not sure of the value of having a Docker image of this bot. Sure, it's easy to setup, but... you're inside a sandbox, most basic commands aren't even there, and most people that use this bot want to control a real box with it... the Docker install won't allow that. 🤔

@yozel
Copy link
Author

yozel commented Feb 23, 2019

Thanks for the PR! But I'm not sure of the value of having a Docker image of this bot. Sure, it's easy to setup, but... you're inside a sandbox, most basic commands aren't even there, and most people that use this bot want to control a real box with it... the Docker install won't allow that.

I was using shell-bot to provide a quick linux shell for my telegram groups. But I agree with you, this won't be helpful in case of a real box.

@retrojon
Copy link

Thanks @yozel for the Dockerize project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants