Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change sendRequestInternal from private to protected #380

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

cobr123
Copy link
Contributor

@cobr123 cobr123 commented Mar 14, 2024

This PR provide a change of sendRequestInternal method from private to protected for opportunity to override apply method without copying of sendRequestInternal method.

…to override apply method without copying of sendRequestInternal method
@ex0ns
Copy link
Contributor

ex0ns commented Mar 29, 2024

Sorry for the delay, I missed the notification
I don't really see any issue with this changes, and that would enable user to add new/not yet supported messages

Thanks for the PR, going to publish a new version asap

@ex0ns ex0ns merged commit b324306 into bot4s:main Mar 29, 2024
1 check passed
@ex0ns
Copy link
Contributor

ex0ns commented Mar 29, 2024

version 5.8.0 is out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants