Feature: add meta on get hooks

[JuraJuki]

• references Add meta in getAll requests #16

[renatoruk]

Looks pretty good, it will be a helpful addition!

Some things to keep in mind:

• these would be awesome to cover with
• there is a change some of these getOperationMeta calls are incomplete as they're missing id and request method (I think the compiler does not warn about it because they're optional)

[JuraJuki]

@renatoruk updated get tests with meta expects. Added additional params for getOperationMeta. If ID is passed at useGet or useGetControlled the meta returned is undefined.

Checked the checkboxes

[renatoruk]

@renatoruk updated get tests with meta expects. Added additional params for getOperationMeta. If ID is passed at useGet or useGetControlled the meta returned is undefined.

Checked the checkboxes

Looks good!

If ID is passed at useGet or useGetControlled the meta returned is undefined.
Not sure if this is expected behaviour or a bug?

[codecov]

Codecov Report

Merging #38 into master will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   85.41%   85.57%   +0.16%     
==========================================
  Files          49       49              
  Lines        1049     1061      +12     
  Branches      161      161              
==========================================
+ Hits          896      908      +12     
  Misses        151      151              
  Partials        2        2              

Impacted Files	Coverage Δ
src/hooks/useGet.ts	100.00% <100.00%> (ø)
src/hooks/useGetAll.ts	100.00% <100.00%> (ø)
src/hooks/useGetAllControlled.ts	92.85% <100.00%> (+0.85%)	⬆️
src/hooks/useGetControlled.ts	91.30% <100.00%> (+1.30%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0955069...43015c2. Read the comment docs.

[JuraJuki]

@renatoruk updated get tests with meta expects. Added additional params for getOperationMeta. If ID is passed at useGet or useGetControlled the meta returned is undefined.
Checked the checkboxes

Looks good!

If ID is passed at useGet or useGetControlled the meta returned is undefined.
Not sure if this is expected behaviour or a bug?

It is a bug, it should return meta :C

[renatoruk]

@renatoruk updated get tests with meta expects. Added additional params for getOperationMeta. If ID is passed at useGet or useGetControlled the meta returned is undefined.
Checked the checkboxes

Looks good!

If ID is passed at useGet or useGetControlled the meta returned is undefined.
Not sure if this is expected behaviour or a bug?

It is a bug, it should return meta :C

Did you have the time to work on this? As you said, it's prerequisite for #41

[JuraJuki]

@renatoruk updated get tests with meta expects. Added additional params for getOperationMeta. If ID is passed at useGet or useGetControlled the meta returned is undefined.
Checked the checkboxes

Looks good!

If ID is passed at useGet or useGetControlled the meta returned is undefined.
Not sure if this is expected behaviour or a bug?

It is a bug, it should return meta :C

Did you have the time to work on this? As you said, it's prerequisite for #41

I did not sadly, should be having a couple of hours in the next few days so I will take a lot. Or perhaps you wish to take a look?

[renatoruk]

@renatoruk updated get tests with meta expects. Added additional params for getOperationMeta. If ID is passed at useGet or useGetControlled the meta returned is undefined.
Checked the checkboxes

Looks good!

If ID is passed at useGet or useGetControlled the meta returned is undefined.
Not sure if this is expected behaviour or a bug?

It is a bug, it should return meta :C

Did you have the time to work on this? As you said, it's prerequisite for #41

I did not sadly, should be having a couple of hours in the next few days so I will take a lot. Or perhaps you wish to take a look?

Can you make the tests actually fail (prepare them with the real expected result) so it's easier to debug on what is needed?