Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move open3d to from pip to config dependency and remove duplicate pycolmap dependency #809

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Move open3d to from pip to config dependency and remove duplicate pycolmap dependency #809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ To run GTSfM, first, we need to create a conda environment with the required dep
On **Linux**, with CUDA support, run:

```bash
conda env create -f environment_linux.yml
conda activate gtsfm-v1 # you may need "source activate gtsfm-v1" depending upon your bash and conda set-up
mamba env create -f environment_linux.yml
mamba activate gtsfm-v1 # you may need "source activate gtsfm-v1" depending upon your bash and conda set-up
Comment on lines +34 to +35
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we changing to mamba?

```

On **macOS**, there is no CUDA support, so run:
Expand Down
3 changes: 1 addition & 2 deletions environment_mac.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,13 @@ dependencies:
- tabulate
- simplejson
- pycolmap
- open3d
# testing
- parameterized
- pip:
- open3d
- opencv-python>=4.5.4.58 # pypi has a more recent distribution than conda-forge
- pydegensac
- colour
- trimesh[easy]
- pycolmap>=0.1.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pycolmap is already configured on line 51.

- gtsam==4.2
- pydot
Loading