[iOS] 여정 리스트 Scene UI #98
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhiteHyun
reviewed
Nov 24, 2023
Comment on lines
1
to
7
| #!/bin/sh | ||
|
|
||
| LINTPATH='.swiftlint.yml' | ||
| declare -a PATHS=("MSCoreKit" "MSFoundation" "MSUIKit" "MusicSpot") | ||
| declare -a PATHS=("MSCoreKit" "MSFoundation" "MSUIKit" "MusicSpot" "Features") | ||
| failures="" | ||
|
|
||
| for path in "${PATHS[@]}"; do |
There was a problem hiding this comment.
안녕하세요 승현님 😊
commit 할 때마다 Lint 돌리려고 Path 지정해준겁니다... ㅎㅎ
There was a problem hiding this comment.
아 githooks precommit으로 사용중인 건가보군요? 감사합니다 ㅎㅎ
There was a problem hiding this comment.
precommit은 여러가지 이유로 못쓰고 있고..
commit 실행 파일 실행해서 사용하고 있습니다 😅
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ 배경
close #75
🔧 작업 내역
🧪 테스트 방법
📝 리뷰 노트
임의로 ViewModel을 만들어서 Mock 데이터를 넣어뒀습니다.
모델 타입도 임의로
Journey와Spot을 만들어뒀습니다.이후에 연결하며 실제 로직 구현할 때 실제 타입으로 대체하면 될 것 같습니다.
현재 "지난 여정"과 여정 개수를 출력하는 타이틀 부분이 왼쪽에 딱 붙어있는데,
BaseViewController에서 설정한additionalSafeAreaInset에 맞춰 작업해서 그렇습니다.머지되고 적용하면 정상적으로 출력될 듯 합니다.
📸 스크린샷