Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ 배경
🔧 작업 내역
MSPersistentStorage
리팩토링📝 리뷰 노트
1️⃣ KeychainStorage
MSKeychainStorage
의 로직이 PersistentStorage와 동일한데도 불구하고MSPersistentStorage
프로토콜을 따르지 않고 있었습니다.따라서 해당 프로토콜을 채택하여 사용하도록 수정했습니다.
또한
MSKeychainStorage
대신FileManagerStorage
나CoreDataStorage
와 동일하게 MS prefix를 제거한KeychainStorage
로 네이밍을 수정하였습니다.2️⃣ RecordingJourneyStorage
RecordingJourneyStorage
가MSPersistentStorage
를 채택하지 않고 사용된다는 점의 사유로
RecordingJourneyStorage
의 네이밍을RecordingJourneyService
로 변경해주었습니다.📸 스크린샷