Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps, force errors as messages #12

Merged
merged 5 commits into from
Mar 7, 2024
Merged

Update deps, force errors as messages #12

merged 5 commits into from
Mar 7, 2024

Conversation

vearutop
Copy link
Member

@vearutop vearutop commented Mar 6, 2024

No description provided.

Copy link

github-actions bot commented Mar 6, 2024

Lines Of Code

Language Files Lines Code Comments Blanks Complexity Bytes
Go 1 378 (+10) 280 (+5) 14 84 (+5) 56 7K (+120B)
Go (test) 4 417 373 13 31 5 12.1K (-15B)
YAML 6 486 (+56) 400 (+34) 36 50 (+22) 0 16.1K (+2K)

Copy link

github-actions bot commented Mar 6, 2024

Go API Changes

# summary
Inferred base version: v1.1.0
Suggested version: v1.2.0

Copy link

github-actions bot commented Mar 6, 2024

Benchmark Result

Benchmark diff with base branch
name          old time/op    new time/op    delta
SugaredZap-4     672ns ± 1%     674ns ± 1%    ~     (p=0.429 n=6+5)
CtxFull-4       1.57µs ± 0%    1.59µs ± 0%  +1.23%  (p=0.004 n=5+6)
CtxLite-4        852ns ± 1%     822ns ± 1%  -3.45%  (p=0.002 n=6+6)

name          old alloc/op   new alloc/op   delta
SugaredZap-4      256B ± 0%      256B ± 0%    ~     (all equal)
CtxFull-4         768B ± 0%      832B ± 0%  +8.33%  (p=0.002 n=6+6)
CtxLite-4         256B ± 0%      256B ± 0%    ~     (all equal)

name          old allocs/op  new allocs/op  delta
SugaredZap-4      1.00 ± 0%      1.00 ± 0%    ~     (all equal)
CtxFull-4         8.00 ± 0%      8.00 ± 0%    ~     (all equal)
CtxLite-4         1.00 ± 0%      1.00 ± 0%    ~     (all equal)
Benchmark result
name          time/op
SugaredZap-4   674ns ± 1%
CtxFull-4     1.59µs ± 0%
CtxLite-4      822ns ± 1%

name          alloc/op
SugaredZap-4    256B ± 0%
CtxFull-4       832B ± 0%
CtxLite-4       256B ± 0%

name          allocs/op
SugaredZap-4    1.00 ± 0%
CtxFull-4       8.00 ± 0%
CtxLite-4       1.00 ± 0%

Copy link

github-actions bot commented Mar 7, 2024

Unit Test Coverage

total: (statements) 96.6%
changed lines: (statements) 100.0%

Coverage of changed lines
File Function Coverage
Total 100.0%
logger.go 100.0%
logger.go:133 Debug 100.0%
logger.go:192 Info 100.0%
logger.go:227 Important 100.0%
logger.go:262 Warn 100.0%
logger.go:297 Error 100.0%
Coverage diff with base branch
File Function Base Coverage Current Coverage
Total 96.5% 96.6% (+0.1%)
logger.go Error 93.3% 93.8% (+0.5%)
logger.go Important 93.3% 93.8% (+0.5%)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.79%. Comparing base (862eec4) to head (738026d).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
+ Coverage   94.64%   94.79%   +0.15%     
==========================================
  Files           1        1              
  Lines         168      173       +5     
==========================================
+ Hits          159      164       +5     
  Misses          5        5              
  Partials        4        4              
Flag Coverage Δ
unittests 94.79% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vearutop vearutop merged commit ab7791b into master Mar 7, 2024
7 checks passed
@vearutop vearutop deleted the force-errors branch March 7, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants