TimeLagSeries function fix #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-demianchuk
requested review from
grzkv,
azhiltsov,
timtofan,
emadolsky and
deniszh
as code owners
deniszh
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue is this change attempting to solve?
TimeSeriesLag function calculates time-based lag (e.g. for Kafka offsets) based on two offsets metrics - consumer and producer.
Currently the lag function has a bug that produces negative values in some cases.
This MR simplifies and updates the logic of the function, and fixes this bug.
How does this change solve the problem? Why is this the best approach?
Code changes make the logic of lag calculation more understandable and account for the bug that was producing the negative values
How can we be sure this works as expected?
Additional tests were added, broken tests were fixed