Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove extra top margin in the toc when there is no message block #233

Merged

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Aug 14, 2024

Only apply an extra top margin when the HTML generation that a message block is used.

Closes #123

Notes

TOC position before and after the fix in the "Showcase" page of the Theme preview:

PR_233_fix_toc_top-margin_when_no_message_block

Only apply an extra top margin when the HTML generation that a message block is used.
Copy link

github-actions bot commented Aug 14, 2024

🎊 PR Preview 0398049 has been successfully built and deployed to https://bonitasoft-bonita-documentation-theme-build_preview-pr-233.surge.sh

🕐 Build time: 0.01s

🤖 By surge-preview

@tbouffard tbouffard marked this pull request as ready for review August 14, 2024 14:41
@tbouffard tbouffard added the bug Something isn't working label Aug 28, 2024
@tbouffard
Copy link
Member Author

Putting in draft, to test the preview after #234 has been merged.

@tbouffard tbouffard marked this pull request as draft September 4, 2024 08:43
Copy link

sonarqubecloud bot commented Sep 4, 2024

@tbouffard
Copy link
Member Author

✔️ tested preview after #234 has been merged.

@tbouffard tbouffard marked this pull request as ready for review September 4, 2024 09:01
@benjaminParisel benjaminParisel merged commit c23552b into master Sep 4, 2024
4 checks passed
@benjaminParisel benjaminParisel deleted the fix/123_remove_extra-margin-top_table_content_on_right branch September 4, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

Remove extra margin-top in the table of content of the page
2 participants