Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide link to related latest page for "out of support" pages #230

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Aug 8, 2024

Previously, in the "out of support", the link to the "latest" resource was always targeting the home page of the latest version of the component.
Now, the link targets the latest version of the current page when it exists. The template use the "relativize" helper to make the url work with local file browsing

Also update the model-ui.yml used for the preview to demonstrate the change.

Notes

Closes #203

Additional tests

Tested with preview source

Locally tested with doc-site and test data from bonitasoft/bonita-documentation-site#762:

  • command: ./build-preview-dev.bash --local-ui-bundle --use-test-sources
  • generated content: site_test-data.zip

Locally tested with doc-site and part of the real bonita doc content

  • command: ./build-preview-dev.bash --local-ui-bundle -local-sources --use-multi-repositories --component-with-branches bonita:7.11,2022.2
  • content is too large to be shared (more than 100 mb, and GitHub only accept 25 mb)

Previously, in the "out of support", the link to the "latest" resource was always targeting the home
page of the latest version of the component.
Now, the link targets the latest version of the current page when it exists.
The template use the "relativize" helper to make the url work with local file browsing

Also update the model-ui used for the preview to demonstrate the change.
Copy link

sonarqubecloud bot commented Aug 8, 2024

Copy link

github-actions bot commented Aug 8, 2024

🎊 PR Preview ed6c2c1 has been successfully built and deployed to https://bonitasoft-bonita-documentation-theme-build_preview-pr-230.surge.sh

🕐 Build time: 0.01s

🤖 By surge-preview

@tbouffard tbouffard marked this pull request as ready for review August 8, 2024 14:24
@benjaminParisel benjaminParisel merged commit e82eebb into master Aug 14, 2024
9 checks passed
@benjaminParisel benjaminParisel deleted the feat/out-of-support_link_to_new_page_not_component_home branch August 14, 2024 12:09
@tbouffard tbouffard added the enhancement New feature or request label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
2 participants