Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: build with node18 #216

Merged
merged 5 commits into from
May 29, 2024
Merged

chore: build with node18 #216

merged 5 commits into from
May 29, 2024

Conversation

benjaminParisel
Copy link
Contributor

@benjaminParisel benjaminParisel commented Apr 4, 2024

Node16 is deprecated since few months, it's time to jump in the "future" and use node18.

@benjaminParisel benjaminParisel added the dependencies Pull requests that update a dependency file label Apr 4, 2024
Copy link

github-actions bot commented Apr 4, 2024

♻️ PR Preview 483a1e1 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

Copy link

sonarqubecloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tbouffard tbouffard changed the title chore: Allow to build with node18 chore: build with node18 Apr 9, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Tested with the surge preview environment
✔️ Tested locally

  • npm run bundle
  • dev mode

@tbouffard tbouffard merged commit 2e30505 into master May 29, 2024
3 checks passed
@tbouffard tbouffard deleted the chore/update_dependencies branch May 29, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants