Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unpin setuptools #68

Closed
wants to merge 3 commits into from
Closed

unpin setuptools #68

wants to merge 3 commits into from

Conversation

bodono
Copy link
Owner

@bodono bodono commented Oct 4, 2023

No description provided.

SteveDiamond
SteveDiamond approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@SteveDiamond SteveDiamond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enzbus
Copy link
Contributor

enzbus commented Oct 5, 2023

Both pkgutil.ImpImporter (which is called by the old setuptools.build_meta, without this PR) and numpy.distutils (which is called with this PR) were deprecated and have been removed in 3.12. Also, numpy has switched to meson build...

@enzbus enzbus mentioned this pull request Oct 5, 2023
Closed
@bodono bodono closed this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveDiamond SteveDiamond SteveDiamond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bodono @enzbus @SteveDiamond