Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.13 #117

Merged
merged 9 commits into from
Nov 21, 2024
Merged

Support Python 3.13 #117

merged 9 commits into from
Nov 21, 2024

Conversation

jonadaly
Copy link
Contributor

@jonadaly jonadaly commented Oct 15, 2024

Hi @bodono , I tried to mirror your changes from my previous request to support Python 3.12 / MacOS - now for the new release of Python 3.13!

I've also removed support for Python 3.8 since it's now end-of-life.

@bodono
Copy link
Owner

bodono commented Oct 16, 2024

Thanks for looking into this @jonadaly ! It looks like one the python 3.9 run on windows is failing, possibly due to an incompatible numpy version, do you have any ideas on how to fix that? Once fixed we can land this!

@jonadaly
Copy link
Contributor Author

I'm not sure why that's happening - what's weird is that fixing it seems to have broken the 3.12 build! 😆

@bodono
Copy link
Owner

bodono commented Nov 1, 2024

I'm not sure why that's happening - what's weird is that fixing it seems to have broken the 3.12 build! 😆

We could drop support for 3.9 too, that's less than a year from EOL, if we do that and revert back to when 3.12 was working we can land this.

@bodono
Copy link
Owner

bodono commented Nov 1, 2024

And sorry for the delay in responding! Thanks for putting effort into this.

@jonadaly
Copy link
Contributor Author

So I've got the CI passing by removing the "legacy build" for >3.11. Not sure how legit that is though - what do you think @bodono ?

@@ -166,7 +156,7 @@ jobs:
shell: bash
run: |
echo "PYTHON_SUBVERSION=$(echo $PYTHON_VERSION | cut -c 3-)" >> $GITHUB_ENV
echo "SINGLE_ACTION_CONFIG=$( [[ $PYTHON_VERSION == 3.8 && $RUNNER_OS == 'macOS' ]] && echo 'True' || echo 'False' )" >> $GITHUB_ENV
echo "SINGLE_ACTION_CONFIG=False" >> $GITHUB_ENV
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is just always False then we can just remove it, and from line 175 below.

@bodono
Copy link
Owner

bodono commented Nov 15, 2024

Thanks @jonadaly, LGTM after minor update I suggested. Let me know when you think it is ready to merge and I can do it.

@jonadaly
Copy link
Contributor Author

Thanks @jonadaly, LGTM after minor update I suggested. Let me know when you think it is ready to merge and I can do it.

@bodono Done!

@bodono
Copy link
Owner

bodono commented Nov 21, 2024

Thanks!

@bodono bodono merged commit fa64e28 into bodono:master Nov 21, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants