Prevent a serial RX overflow if the port is in FIFO mode #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DrChat
commented
Apr 16, 2024
DrChat
commented
- If the guest's serial port is in FIFO mode and is almost full, throttle new inputs so that an RX overflow error isn't triggered. This is necessary because a host process on the other end is much faster than the guest, so it can easily overflow the port and cause the guest to discard data.
- Open named pipes in an asynchronous mode, just so something is not required to connect to the pipe on startup. This has been a useful change for me, but if it is too problematic I can remove it.
DrChat
commented
Apr 16, 2024
| if ((BX_SER_THIS s[port].line_status.rxdata_ready == 0) || | ||
| (BX_SER_THIS s[port].fifo_cntl.enable)) { | ||
| ((BX_SER_THIS s[port].fifo_cntl.enable) && (BX_SER_THIS s[port].rx_fifo_end < 15))) { |
There was a problem hiding this comment.
Not sure what your thoughts are on applying this to BX_SER_MODE_RAW - that's the only odd one out here.
vruppert
reviewed
Apr 19, 2024
|
@vruppert I've confirmed that it all works locally, though I cannot confirm if it breaks anyone's expectations. |
|
is this PR still relevant or already should be dropped ? |
|
I haven't worked with serial port for a long time and I never tried the "pipe" modes. At the moment I have no chance to test it. |
|
The fix on line 1545 is definitely still relevant. Let me follow up and drop the other changes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.