-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds drag and drop capability to 2d token #316
Conversation
For some reason this PR seems to be affecting the overall project coverage status (on master) as reported by Coveralls. Weird! |
How so? This is not even merged yet, very weird. |
No, for some reason Coveralls thinks that this is a commit made on the I'm not sure if it is Coveralls that's broken or the CI that's sending over incorrect branch data for PR's. |
Some behavioral comments:
|
Ok, I will take a look into this later and get back to you. |
@nicolodavis These issues should be addressed now. I also needed to add some logic to handle mobile better, which is so annoying, because touch screen behaves a little bit different than mouse. I am using this in my new game, and it works well in mobile with the right CSS to avoid scrolling. Do you have any idea when you will merge the 3d branch into master? because I am having to maintain a separate fork in order to be able to use this in my project. Do you need help with anything in order to merge? I saw that there is a lot of untested code in the 3d folder. |
The code I sent works in desktop, android but not iOs. I am changing it to work everywhere. It is very ugly but each environment behaves differently... |
OK, the code now works on iOs, Android, Chrome desktop... I spent hours and hours trying to figure out a way to abstract away all this mess, and I think I succeeded :D |
I'll try to merge the 3d branch in after this PR. There hasn't been much progress on the 3D components, so maybe I'll scrap it for the v1 release and add it as a nice to have for later. |
FYI, I just found out that the click isnt working for Android. I will fix it soon... wait for merging |
Ok, now it works on Android too :) |
Checklist
master
).