Added semver checks

[Razican]

This Pull Request adds SemVer checks to our CI. This comes under the idea of releasing more often, and trying to release semver-compatible releases if possible.

It changes the following:

• Changes the current version to 0.17.1-dev, while we develop the new version
• Uses cargo-semver-checks to make sure we are semver-compatible.

[github-actions]

Test262 conformance changes

Test result	main count	PR count	difference
Total	95,609	95,609	0
Passed	75,926	75,926	0
Ignored	18,924	18,924	0
Failed	759	759	0
Panics	0	0	0
Conformance	79.41%	79.41%	0.00%

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cec9892) 45.64% compared to head (040e51a) 45.45%.
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3173      +/-   ##
==========================================
- Coverage   45.64%   45.45%   -0.19%     
==========================================
  Files         483      483              
  Lines       49517    49743     +226     
==========================================
+ Hits        22600    22613      +13     
- Misses      26917    27130     +213     

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jedel1043]

Seeing that this modifies our CI, can we also repair our release action? I'm pretty sure we removed the rust publish command for release fixes

[Razican]

Seeing that this modifies our CI, can we also repair our release action? I'm pretty sure we removed the rust publish command for release fixes

Done :)

[nekevss]

Oh, the version should be 0.18.0-dev instead of 0.17.1-dev, right?

[Razican]

Oh, the version should be 0.18.0-dev instead of 0.17.1-dev, right?

Well, for now we have no semver-incompatible changes, so it would be 0.17.1

[jedel1043]

Thanks!

[nekevss]

Well, for now we have no semver-incompatible changes, so it would be 0.17.1

The gc changes that were merged last night had API changes I think, which is why CI is currently failing with 0.17.1-dev as the version.

[jedel1043]

Saw that the semver action was failing. We should probably fix that before merging

[Razican]

I have opened obi1kenobi/cargo-semver-checks#570 to track the issue.

[jedel1043]

@Razican Do you have any updates on this or the linked issue? Maybe this just needs a rebase.

[Razican]

@Razican Do you have any updates on this or the linked issue? Maybe this just needs a rebase.

I didn't have a chance to work on this :( I would like to first test that the PR checks work fine, and that they correctly read the new JSON format.

Then, a rebase would make the trick :)

If you have some time to work on it, please, do it. If not, I'll try to work on it this week or the next.

[obi1kenobi]

👋 Hi! I'm the maintainer of cargo-semver-checks and I noticed this issue.

As far as I can tell from the logs, the proximate cause of the error is a cargo doc failure to generate rustdoc JSON for boa_icu_provider. The command it ran (and which errored out due to a compilation error) was:

RUSTDOCFLAGS="-Z unstable-options --document-private-items --document-hidden-items --output-format=json --cap-lints allow" cargo doc --package boa_icu_provider --no-deps

It seems plausible based on the log that the cause of the compilation failure was a semver violation in icu_provider or icu_decimal or another crate. If so, a rebase plus cargo update might resolve it, and are worth a shot.

Note that cargo-semver-checks ignores the Cargo.lock file and uses newer dependencies when available and allowed under their version bounds (explanation why). To replicate the failure, it might be necessary to cargo update first.

I would like to first test that the PR checks work fine, and that they correctly read the new JSON format.

I can hopefully save you a step or two here: cargo-semver-checks supports all JSON formats from Rust 1.71 to the most recent nightly. I get emails when a new rustdoc JSON format is merged, and we also test this in CI, so I'm quite sure the issue is not a JSON format incompatibility.

Thanks for checking out cargo-semver-checks! I'm the only maintainer, and it's a donation-supported project, so I'm doing my best to support the community while also providing for my family. Hope you find it useful, and if so, I'd love to know — it would make my day! 😃