refactor: deleteMembers 분리

bo-an-bo · Apr 19, 2024 · 65acaee · 65acaee
1 parent 39831b4
commit 65acaee
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/group/group.service.ts b/src/group/group.service.ts
@@ -44,6 +44,14 @@ export class GroupService {
     return this.groupRepository.delete(groupId);
   }
 
+  async deleteMember(groupId: string, memberId: string): Promise<void> {
+    const group = (await this.groupRepository.findOne(groupId)) as Group;
+    if (group.members.includes(memberId)) {
+      group.members = group.members.filter((member) => member !== memberId);
+    }
+    await this.groupRepository.update(groupId, group);
+  }
+
   async deleteMembers(groupId: string, memberIds: string[]): Promise<void> {
     const group = (await this.groupRepository.findOne(groupId)) as Group;
     const groupMembers = group.members;

diff --git a/src/member/member.service.ts b/src/member/member.service.ts
@@ -74,7 +74,7 @@ export class MemberService {
     if (!this.validateMemberIds(memberIds)) throw new NotFoundException();
 
     this.memberRepository.delete(memberIds);
-    await this.groupService.deleteMembers(groupId, memberIds);
+    await this.groupService.deleteMember(groupId, memberId);
   }
 
   async deleteGroupMembers(