Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the Boolean function manipulation features of PyEDA with AEON using an updated DNF algorithm that is much better at generating "syntactically monotonic" DNF representations.
I've added a basic benchmark using a group of collected models to compare the performance. All the benchmark is doing is computing the first minimal trap space, so it has to generate the ASP encoding and run
clingo
. However, it is not running any correctness checks, since for that we would need all the minimal trap spaces. The actual data from the comparison is linked at the end of the pull request.Main things to consider:
is_unate_symbolic
method to test that, but it is not used anywhere at the moment; I just used it for testing and figured it could be useful in the future.Overall, if it was easy to keep using PyEDA, a portfolio approach that combines both would make sense. But if PyEDA is no longer maintained, it seems that AEON should be on average just as good, even though it isn't completely superior.
Comparison table: https://docs.google.com/spreadsheets/d/1-RSaHbcmGX8NVvQ36081FaEnHAc53uHjyPUTB4t7yDE/edit?usp=sharing
Raw data:
baseline.zip
current.zip