Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-extension entitlements #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

russriser
Copy link

This PR fixes an issue where the entitlements for a pre-existing extension are overwritten.

Since the configIndex is set to 0 before writing the entitlements, we need to make sure we add the new extension at index 0, not to the end of the list.

@nathan-ahn
Copy link
Collaborator

nathan-ahn commented Dec 11, 2024

@russriser Your code makes sense for fixing pre-existing extensions getting overwritten, but I can't figure out what the original code was intended to do. I might be reading your PR incorrectly, but it appears that this entire section now becomes useless

if (configIndex != null && config.extra) {
    const appClipConfig =
      config.extra.eas.build.experimental.ios.appExtensions[configIndex];
    appClipConfig.entitlements = {};
}

since appClipConfig (which I think should be widgetConfig) is never created with entitlements. Do you see any reason to not just delete the entirety of the above section?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants