Fix: Relationships on subquery model.

[hvdklauw]

It was using the field name instead of the field column which resulted in errors for related fields.

This way other related models work as excepted, but it will issue a query.

[hvdklauw]

Hmm this actually breaks still on the ManyToOne relations...

[hvdklauw]

Maybe change it to:

declared = {f.column for f in model._meta.get_fields() if f.concrete}

But that needs some tests.

[hvdklauw]

Fixed it by adding a shelve model to keep books on, so that there is a non concrete manytomany field on the book model to throw the expected

[hvdklauw]

Ugh, the other side of a manytomany is a concrete field with a column that isn't actually in the database. (default django user groups field)

Which is weird?
https://docs.djangoproject.com/en/5.0/ref/models/fields/#django.db.models.Field.concrete states that the concrete is there to define if there is a database column, which is what we want for this.

[bmispelon]

(I've merged black and isort support + CI so I took the liberty to rebase this branch, I hope that was ok)

[hvdklauw]

No problem, seems I sort is failing, but no clear error. I'll have a look later when I have time.

[bmispelon]

No problem, seems I sort is failing, but no clear error. I'll have a look later when I have time.

I think it doesn't like the empty line you removed in testproject/testapp/models.py. Do you have an automatic isort in your text editor? Which config does that use?

[hvdklauw]

I think I might have ruff configured with default settings, not sure and not at my dev laptop right now to check.

[bmispelon]

I think I'm going to make isort happy then merge this. Seems like a net positive.

[bmispelon]

Thanks again for the contribution! 🚀