Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hide bottom pages that need su if apd is not installed #96

Merged
merged 2 commits into from
Jan 11, 2024
Merged

feat: hide bottom pages that need su if apd is not installed #96

merged 2 commits into from
Jan 11, 2024

Conversation

ponces
Copy link
Contributor

@ponces ponces commented Jan 11, 2024

No description provided.

@marat2509
Copy link
Collaborator

Any screen/video?

@ponces
Copy link
Contributor Author

ponces commented Jan 11, 2024

Any screen/video?

Sure!

screen-20240111-145123.1.mp4

@marat2509
Copy link
Collaborator

Not considered is that even when AndroidPatch is not installed, root rights can still be obtained (more often via running /system/bin/kp) by adding the app to the su list beforehand. Also the kp modules tab should not be hidden if kpatch is installed.

@ponces
Copy link
Contributor Author

ponces commented Jan 11, 2024

Not considered is that even when AndroidPatch is not installed, root rights can still be obtained (more often via running /system/bin/kp) by adding the app to the su list beforehand. Also the kp modules tab should not be hidden if kpatch is installed.

This is a bit inspired by what ksu does too.
You're right but I was considering the state of apatch for this. I can easily consider su access if provided by kp.
I'll update it later, thanks for the suggestions.

@ponces ponces marked this pull request as draft January 11, 2024 18:10
@ponces
Copy link
Contributor Author

ponces commented Jan 11, 2024

Ok, so this is the current states scenario:

  • Home -> always available, no state dependency
  • KModule -> available on all states besides the "unknown" state which means kpatch not installed
  • SuperUser -> only available if su exists
  • AModule -> only available if apatch is installed ("ready" or "needing update" or "installing")

@marat2509
Copy link
Collaborator

marat2509 commented Jan 11, 2024

  • SuperUser -> only available if su exists

Only available if kpatch is installed.

Try: uninstall AndroidPatch, clear the su list, open termux/terminal, type /system/bin/kp, doesn't work? everything is fine (because the app is not in the su list), add termux/terminal to the su list, try again.

@ponces
Copy link
Contributor Author

ponces commented Jan 11, 2024

  • SuperUser -> only available if su exists

Only available if kpatch is installed.

Try: uninstall AndroidPatch, clear the su list, open termux/terminal, type /system/bin/kp, doesn't work? everything is fine (because the app is not in the su list), add termux/terminal to the su list, try again.

So you mean that both "KModule" and "SuperUser" pages should benefit from the same conditions which is "if kpatch is installed". Is this correct?

@marat2509
Copy link
Collaborator

should benefit from the same conditions which is "if kpatch is installed". Is this correct?

Yes.

@ponces
Copy link
Contributor Author

ponces commented Jan 11, 2024

I added some tasks for vscode to easily built this by a shortcut but I can remove if you agree to be useless for the dev community

@ponces ponces marked this pull request as ready for review January 11, 2024 21:55
@marat2509 marat2509 merged commit 22f8dde into bmax121:main Jan 11, 2024
2 checks passed
@ponces ponces deleted the main-hide-bottom-dest branch January 11, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants