encode positive int/int64 as uint/uint64, fixes #7

blugnu · Nov 16, 2023 · bc63f16 · bc63f16
1 parent a309633
commit bc63f16
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/.gitignore b/.gitignore
@@ -19,3 +19,6 @@
 
 # Go workspace file
 go.work
+
+# vscode settings
+.vscode
diff --git a/encoder.int.family.go b/encoder.int.family.go
@@ -141,7 +141,7 @@ func (enc Encoder) EncodeInt64(i int64) error {
 		return enc.Write(uint32(i))
 
 	default:
-		_ = enc.Write(typeInt64)
+		_ = enc.Write(typeUint64) // keeps sonarcloud happy by not duplicating the case for < MinInt32 (positive int64/uint64 are identical)
 		return enc.Write(i)
 	}
 }
@@ -271,7 +271,7 @@ func (enc Encoder) EncodeInt(i int) error {
 		return enc.Write(uint32(i))
 
 	default:
-		_ = enc.Write(typeInt64)
+		_ = enc.Write(typeUint64) // keeps sonarcloud happy by not duplicating the case for < MinInt32 (positive int64/uint64 are identical)
 		return enc.Write(int64(i))
 	}
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -19,3 +19,6 @@ @@
     # Go workspace file
     go.work
+    # vscode settings
+    .vscode