Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit create_all transaction. #703

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

danielballan
Copy link
Member

@danielballan danielballan commented Mar 29, 2024

via @kleinhenz in #616

@danielballan
Copy link
Member Author

We call create_all() in one other place, for the catalog database, but that one already has the necessary commit call:

# Create all tables.
await connection.run_sync(Base.metadata.create_all)
if engine.dialect.name == "sqlite":
# Use write-ahead log mode. This persists across all future connections
# until/unless manually switched.
# https://www.sqlite.org/wal.html
await connection.execute(text("PRAGMA journal_mode=WAL;"))
await connection.commit()

Copy link
Contributor

@dylanmcreynolds dylanmcreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@danielballan danielballan merged commit eda0499 into bluesky:main Apr 1, 2024
8 checks passed
@kleinhenz
Copy link
Collaborator

Thanks!

@danielballan danielballan mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants