Add status repr to WaitTimeoutError message #1088
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a similar situation to #1086 , we had an issue where the error message
Status has failed to complete
was not very illuminating as to which status that was, so I have added this information to theraise WaitTimeoutError
calls in the same manner as it is added to other exception messages instatus.py
. This would be really helpful to us in avoiding wrapping everywait()
with try/except to record what we are waiting on or subclassing every kind of status we have to modifywait()
and I hope it might be useful to others too.