Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status repr to WaitTimeoutError message #1088

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

dperl-dls
Copy link
Contributor

In a similar situation to #1086 , we had an issue where the error message Status has failed to complete was not very illuminating as to which status that was, so I have added this information to the raise WaitTimeoutError calls in the same manner as it is added to other exception messages in status.py. This would be really helpful to us in avoiding wrapping every wait() with try/except to record what we are waiting on or subclassing every kind of status we have to modify wait() and I hope it might be useful to others too.

@tacaswell tacaswell merged commit b5a2309 into bluesky:master Jan 23, 2023
@tacaswell
Copy link
Contributor

Thank you @dperl-dls !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants