-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: added all projects toctree to databroker #321
Conversation
Codecov Report
@@ Coverage Diff @@
## master #321 +/- ##
=========================================
Coverage ? 83.11%
=========================================
Files ? 50
Lines ? 6355
Branches ? 922
=========================================
Hits ? 5282
Misses ? 943
Partials ? 130 Continue to review full report at Codecov.
|
this looks good to me (and I'm trusting that it builds when you say it does) |
Let's get Travis's BUILD_DOCS build to pass before we merge. I just kicked it to re-run. Merge at will if/when it passes. |
Probably it needs rebasing and manual resolution of the conflict. |
I think we should revisit whether and how to do this. The number of packages is growing large. Instead of linking to them all, maybe just link to blueskyproject.io? What do you think, @mrakitin? |
I agree with that approach. |
44959b4
to
2c70ac2
Compare
I rebased on master and changed all the project documentation links to a single URL. Does it make sense, @danielballan? |
Thanks! Do you think we should remove the NSLS-II link as well, just to give the right impression? And maybe replace BugReports with the gitter, which is probably a better first place to go for help? |
It's available via 560185a. |
:hidden: | ||
:caption: Getting Help | ||
|
||
Gitter <https://gitter.im/NSLS-II/DAMA> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually --- In the spirit of scrubbing facility-specific branding out, should we move to a bluesky gitter? The way projects do this (e.g. jupyterlab moved from jupyter/jupyterlab -> jupyterlab/jupyterlab) is to post a big message in the gitter with a link to the new one. There is no way to set up an actual redirect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this were mainly an NSLS-II support channel I would say we should leave it as is, but it seems that a fair fraction of the questions we get are from other facilities that are evaluating bluesky.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think moving the gitter to a non NSLS-II would be good, but we can always do that in a follow on PR if we want to merge this one now and then go off and investigate the best way to deal with Gitter.
:hidden: | ||
:caption: Getting Help | ||
|
||
Gitter <https://gitter.im/NSLS-II/DAMA> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree
Good enough for me. We might want to resolve the gitter question before we update all the repos though, to save effort. |
DOC: added all projects toctree to databroker
Description
Add all projects toctree to the databroker documentation.
Motivation and Context
Motivated by NSLS-II/docs#73.
How Has This Been Tested?
Tested locally by building the documentation.