-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AD_HDF5_SINGLE: return sliceable object #32
Conversation
prjemian
commented
Sep 30, 2022
- Is AD_HDF5_SINGLE for general use? #31
The CI failure is because the conf.py file is out of date with current Sphinx. (need to comment the |
I am slightly worried this API change could break other uses of |
I think this is actually a bug and I think this change is mostly backwards compatible (what would you be doing to a list that a N-D stack of numpy arrays would not handle?). I am in favor of merging this but making sure the SXSS AST is very aware of this. |
This may also fix a latent bug that we have not hit at SIX. |
Here's my notebook that relies on this change: https://github.com/BCDA-APS/apstools/blob/691-AD-HDF5-Single-mode/docs/source/examples/de_2_adsim_hdf5_single_mode.ipynb |
@tacaswell - Thanks for the review, and the fix code (that's yours). @danielballan - Thanks for the merge. |