Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: handler for hdf5 files that have variable frames per point #11

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

ENH: handler for hdf5 files that have variable frames per point #11

wants to merge 8 commits into from

Conversation

tacaswell
Copy link
Contributor

Work with @mrakitin to enable variable size images in streams

@mrakitin mrakitin mentioned this pull request Feb 11, 2020
Open
danielballan
danielballan reviewed Feb 11, 2020
View reviewed changes
area_detector_handlers/handlers.py Outdated Show resolved Hide resolved
area_detector_handlers/handlers.py Outdated Show resolved Hide resolved
@danielballan
Copy link
Member

Nice to see! I recall this limitation came up in our recent internal-DAMA ophyd tutorial. Funny that it showed up in the wild so soon after.

mrakitin
mrakitin reviewed Feb 11, 2020
View reviewed changes
Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done the py2->3 conversion.

area_detector_handlers/handlers.py Outdated Show resolved Hide resolved
area_detector_handlers/handlers.py Outdated Show resolved Hide resolved
@mrakitin
Copy link
Member

Also may need https://github.com/bluesky/ophyd/blob/f20c004430dab6dc8d00f9f018f570574928893c/ophyd/ophydobj.py#L297-L307.

@danielballan
Copy link
Member

Can you explain more about the connection to dotted_name?

@mrakitin
Copy link
Member

Can you explain more about the connection to dotted_name?

It's used here: https://github.com/NSLS-II-FXI/profile_collection/pull/3/files#diff-87e76dd09be85349d2409d8fdd9695e9R111-R113.

@danielballan
Copy link
Member

Sorry, still not up to speed on how that relates to the handler code.

@mrakitin
Copy link
Member

My #11 (comment) is not specifically relevant here, but rather is for NSLS-II-FXI/profile_collection#3 in terms of the integration testing on the beamline. Sorry about the confusion.

@danielballan
Copy link
Member

Ohhh right. No, I’m sorry for being dense. :-)

@danielballan danielballan mentioned this pull request Aug 13, 2020
Merged
@danielballan
Copy link
Member

Rebased, satisfied flake8, added entrypoints.

@danielballan
Copy link
Member

This still needs a unit test, but it's ready for testing in the wild at FXI.

@mrakitin mrakitin marked this pull request as ready for review August 26, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrakitin mrakitin mrakitin left review comments

@danielballan danielballan danielballan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tacaswell @danielballan @mrakitin