Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is AD_HDF5_SINGLE for general use? #31

Open
prjemian opened this issue Sep 30, 2022 · 0 comments
Open

Is AD_HDF5_SINGLE for general use? #31

prjemian opened this issue Sep 30, 2022 · 0 comments
Labels
question Further information is requested

Comments

@prjemian
Copy link
Contributor

Via conversations on Slack, it seems the AD_HDF5_SINGLE handler is specific to some HDF5 files generated by the SIX instrument at facility NSLS-II. If so, that's too bad since the name suggests a more general use.

Maybe acknowledge (by stating boldly in the documentation) that AD_HDF5_SINGLE is only for NSLS-II instrument SIX. Make a new handler (say AD_HDF5_GENERAL) which matches the files generated via FileStoreHDF5SingleIterativeWrite (which may need some modification as well). Then, if SIX still uses this mixin, they, alone, would need to customize for their specific use.

One issue noted by @tacaswell with the AD_HDF5_SINGLE handler:

that handler does not conform to what we expect handlers to do (return an ND sliceable thing)

Related to: BCDA-APS/apstools#691

@prjemian prjemian added the question Further information is requested label Sep 30, 2022
prjemian added a commit that referenced this issue Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant