Ask before navigating away from composer #7240
Open
+136
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the 'Discard draft?' post show up if you click on a link within the composer. That fixes a bug where you write a reply to a post and then lose the reply by clicking on the avatar of the person who you’re responding to. You would not be prompted whether you want to discard your draft like when clicking on **Cancel**. This bug also applies to hovering over the avatar and clicking on one of the links there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the Discard draft? post show up if you click on a link within the composer.
That fixes a bug where you write a reply to a post and then lose the reply by clicking on the avatar of the person who you’re responding to. You would not be prompted whether you want to discard your draft like when clicking on Cancel. This bug also applies to hovering over the avatar and clicking on one of the links there, which this fixes too.
This is done by introducing a
ComposerContextthat provides an async function that resolves if the user decided to discard the draft and navigation was thus allowed.Videos