Download images to separate directory on Android #7209
+55
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is my first time contributing to this repo and I'm pretty rusty on my RN/Expo, so please let me know if there's anything I can fix/improve on! |
ClementTsang
force-pushed
the
android_download_images_to_pictures_directory
branch
from
e5a1192 to
aca3e97
Compare
ClementTsang
commented
Dec 20, 2024
This commit addresses the issue on Android where all images are stored in DCIM, which people have complained about. Instead, on Android, it now saves to `Pictures/Bluesky`, by using react-native-blob-util (https://github.com/RonRadtke/react-native-blob-util), which is a more updated fork of rn-fetch-blob.
ClementTsang
changed the title
ClementTsang
force-pushed
the
android_download_images_to_pictures_directory
branch
from
2a89a5e to
24c4c74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue on Android where all images are stored in DCIM, which people have complained about as it interferes with actual pictures for things like Google Photos. Instead, on Android, it now saves to
Pictures/Bluesky, by using react-native-blob-util (https://github.com/RonRadtke/react-native-blob-util), which is a more updated fork of rn-fetch-blob.I've only tested this on an Android emulator (Pixel 8a, Android 13) as of now, can test more if needed.
Closes: #1360