Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iOS hack to fix cropper failing to show #7191

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Add iOS hack to fix cropper failing to show #7191

merged 2 commits into from
Dec 19, 2024

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Dec 19, 2024

Try to work around ivpusic/react-native-image-crop-picker#1631 which for some reason we started hitting. The delay is a bit long but should hopefully be enough for most images.

Test Plan

  • Avi
  • Banner
  • Onboarding

@arcalinea arcalinea temporarily deployed to hack-ios-cropper - social-app PR #7191 December 19, 2024 21:05 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to hack-ios-cropper - social-app PR #7191 December 19, 2024 21:11 — with Render Destroyed
@gaearon gaearon merged commit 25d20c6 into main Dec 19, 2024
7 checks passed
Copy link

Old size New size Diff
6.84 MB 6.84 MB 0 B (0.00%)

gaearon added a commit that referenced this pull request Dec 19, 2024
gaearon added a commit that referenced this pull request Dec 19, 2024
* Revert "Add iOS hack to fix cropper failing to show (#7191)"

This reverts commit 25d20c6.

* Proper fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants