Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(embed): add ability to pin color mode #7074

Closed
wants to merge 3 commits into from

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Dec 12, 2024

What

  • You can now enforce the color mode to dark or light at the embed code author choices (of course you can choose system too).
    • Added an interface to the landing page that allows users to select a color mode.
    • data-bluesky-color-mode attribute is added for embed code (optional, default is system)

Why

Fix #7063

Additional Info

image

@gaearon
Copy link
Collaborator

gaearon commented Dec 12, 2024

I think it would be better to remove the "want to customize" panel and just do a select box ("Theme: System/Dark/Light").

@kakkokari-gtyih
Copy link
Contributor Author

image

@kakkokari-gtyih
Copy link
Contributor Author

Swapped auto with system

image

Copy link

@kankenny kankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate this feat.

@kakkokari-gtyih
Copy link
Contributor Author

I think it would be better to remove the "want to customize" panel and just do a select box ("Theme: System/Dark/Light").

done! (See the image above for reference)

@mozzius
Copy link
Member

mozzius commented Dec 19, 2024

Thanks - I've added some stuff on top of this in #7186, so I'll close this PR. thank you, great work!

@mozzius mozzius closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

embed: add ability to pin the color mode
4 participants