Bsky link card service #4547
Bsky link card service #4547
Conversation
|
Your Render PR Server URL is https://social-app-pr-4547.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cpoge63v2p9s73f67em0. |
|
bskycard/src/routes/starter-pack.tsx
Outdated
| .filter(p => p.avatar) | ||
| // no bad labels | ||
| .filter(p => !p.labels.some(l => hideAvatarLabels.has(l.val))) |
There was a problem hiding this comment.
What does this look like if we don't have a full set of images 🤔
There was a problem hiding this comment.
We had some mockups of this are varying stages, it looked pretty good regardless of the count. Ideally we won't ever have less than 8 but...just in case it doesn't look horrible at all.
There was a problem hiding this comment.
(Assuming we have the same implementation here)
There was a problem hiding this comment.
Yeah, I tested it with all counts down to 1. I think it might be nice to eventually have a fallback design for 1-4, where the background tiling also looks a bit repetitive.
* origin/main: (25 commits) Add a11y context (#4586) center pill text in label pill (#4579) Wait for AppView when posting (#4584) Bsky link card service (#4547) Merge #4492, fixes profile menu hover (#4580) Rework "Who can reply" to blend more nicely into the UI (#4578) Fix threadgate read after write (#4577) Convert button to use forwardRef (#4576) use 1000x1000 for image height in avatar cropper (#4453) fix for autofill covering border (#4573) Update HomeHeaderLayoutMobile.tsx (#4572) Option for large alt badges (#4571) Truncate post metrics and fix truncation on native (#4575) Fix avi placeholder layout (#4570) add support for `ListEmptyComponent`, allow `undefined` data (#4403) GIF previews in notifications (#4447) [Session] Convert account to session data explicitly (#4446) Move onboarding start to after successfull account creation (#4381) Collection of moderation fixes (#4566) Fix undefined block (#4479) ...
This work implements a stateless node service for generating png link card images. It currently supports generating link cards for starter packs at
GET /start/{actor}/{rkey}. Since it's compute-intensive to generate pngs, the service can be run in cluster mode by settingCARD_CLUSTER_WORKER_COUNT.