Allow searching accountds based on more than one signature #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
msi/multi-sign-search - ozone-staging PR #238
Render
Destroyed
foysalit
approved these changes
Nov 19, 2024
app/repositories/page-content.tsx
Outdated
| const res = await labelerAgent.tools.ozone.signature.searchAccounts({ | ||
| values: [value], | ||
| values: values, |
There was a problem hiding this comment.
Suggested change
| values: values, | |
| values, |
| }} | ||
| > | ||
| {children} | ||
| <ConfirmationModal |
There was a problem hiding this comment.
wonder if this component should be pulled out of the button? I've seen weird behavior due to nested components like this inside inline components. this is probably gonna be portaled out of the button anyways so probably doesn't make much of a diff.
matthieusieben
commented
Nov 19, 2024
arcalinea
temporarily deployed
to
msi/multi-sign-search - ozone-staging PR #238
Render
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.