✨ Add dynamic page title to all pages #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://ozone-sandbox-pr-20.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cmrsen6v3ddc73d5ib1g. |
|
Your Render PR Server URL is https://ozone-staging-pr-20.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cmrsen6v3ddc73d5ib4g. |
devinivy
reviewed
Feb 5, 2024
app/events/[id]/page.tsx
Outdated
Comment on lines
24
to
32
| useEffect(() => { | ||
| if (event) { | ||
| const eventTitle = | ||
| MOD_EVENT_TITLES[event.event.$type as string] || 'Moderation' | ||
| document.title = `${eventTitle} Event #${id}` | ||
| } else { | ||
| document.title = `Moderation Event #${id}` | ||
| } | ||
| }, [id, event]) |
There was a problem hiding this comment.
Since the title is just a string which itself can be used as an effect dependency, you could imagine a hook for this like:
function useTitle(title: string) {
useEffect(() => {
document.title = title
}, [title])
}There was a problem hiding this comment.
hmm... I mean we could also use the hook from react-use package since we're using it already across the codebase.
devinivy
approved these changes
Feb 5, 2024
bnewbold
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #19
ozone-ui-page-title.mov