Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lex refactor branch ("last big breaking lexicon changes") #93

Merged
merged 64 commits into from
Apr 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
64 commits
Select commit Hold shift + click to select a range
f235f74
WIP: working through lex refactors
whyrusleeping Mar 27, 2023
c6ee591
Get integration test running
whyrusleeping Mar 28, 2023
b3329a8
likes need to register in decoder
whyrusleeping Mar 28, 2023
6a872fe
labeling: updates for lex refactor
bnewbold Mar 28, 2023
1326b6f
fakermaker: fixes for lex refactor
bnewbold Mar 28, 2023
e57d375
pds: re-add com.atproto.server.getAccountsConfig stubs
bnewbold Mar 28, 2023
be991d1
bgs: fix PDS registration SQL error
bnewbold Mar 28, 2023
1e0c0d0
BGS integ test: bump delay to help CI reliability
bnewbold Mar 28, 2023
5cdb369
replace session.create with server.createSession
bnewbold Mar 28, 2023
b7eae3e
atproto: remove old blob.upload endpoint
bnewbold Mar 28, 2023
fde901c
api: start updating 'did' to 'repo' on repo endpoints
bnewbold Mar 28, 2023
660f1c1
remove old account.* methods
bnewbold Mar 28, 2023
e4ebf57
lexgen again (updated lex refactor branch), including deletions
bnewbold Mar 28, 2023
8ad5325
lexgen: more flexibility
bnewbold Mar 29, 2023
f2d1d9d
another round of lex refactors
bnewbold Mar 29, 2023
91702c6
remove declaration CID from models, etc
bnewbold Mar 29, 2023
672aa93
HACKING: update lexgen docs
bnewbold Mar 29, 2023
1f351be
subscribeAllRepos -> subscribeRepos
bnewbold Mar 29, 2023
c87f2c9
big update of XRPC stubs and handlers (lex refactor)
bnewbold Mar 29, 2023
fe5650a
fakermaker: fix default follower count
bnewbold Mar 29, 2023
bef113e
update lexutil.Blob struct
bnewbold Mar 29, 2023
2064bbc
lexutil.Blob: manual JSON marshaling with cid-link
bnewbold Mar 29, 2023
9170e98
events: update to newer subscription wire protocol
bnewbold Mar 29, 2023
2125de8
fakermaker: include required createdAt on 'like' records
bnewbold Mar 29, 2023
41ddab7
repo subscription refactors (lex updates)
bnewbold Mar 29, 2023
143f76f
lex: update rich text facet
bnewbold Mar 29, 2023
8a404c3
lex: refactor $blob, $link, and $bytes serialization
bnewbold Mar 29, 2023
8bb3a08
lexgen with upstream lex refactors, and + updates
bnewbold Mar 29, 2023
8ed3ce9
update code to work with new LexBlob/LexBytes/LexLink types
bnewbold Mar 29, 2023
67f6a7b
repo slice test: re-enable with lexgen legacy blob working
bnewbold Mar 29, 2023
6972570
fakermaker: include size in blobs
bnewbold Mar 29, 2023
3747614
fakermaker: fix non-lex bug in profile generation
bnewbold Mar 29, 2023
c86f018
lex: CBOR and JSON marshal tests
bnewbold Mar 30, 2023
5fea831
bug fixes in new lex types
bnewbold Mar 30, 2023
bfd6c67
lex: register 'blob' as a decoder type
bnewbold Mar 30, 2023
227485f
lexgen: float, not number (still not used)
bnewbold Mar 30, 2023
6832c50
lexgen: handle 'nullable' fields in struct schemas
bnewbold Mar 30, 2023
f7a0c41
subscribeRepos: re-lexgen for nullable fields
bnewbold Mar 30, 2023
45667ac
events: refactor to new event stream format
bnewbold Mar 30, 2023
60c2bde
refactor to use new event stream format
bnewbold Mar 30, 2023
4db8066
lexutils: MarshalCBOR should operate on refs
bnewbold Mar 30, 2023
a99d8e8
BGS tests: re-enable, with slightly longer sleep
bnewbold Mar 30, 2023
80b1920
sig validation tests (failing in local testing)
bnewbold Mar 30, 2023
1ce4a31
lexgen: CBOR on many LexiconTypeID fields; match JSON omitempty flag
bnewbold Mar 30, 2023
b841fdc
re-run lexgen and cborgen for CBOR change
bnewbold Mar 30, 2023
b94bef8
CBOR union parsing: add failing test
bnewbold Mar 30, 2023
98f7e08
bigsky: don't clobber configured log level
bnewbold Mar 30, 2023
4287685
repomgr: don't error on raw CIDs (eg, blobs) in records
bnewbold Mar 30, 2023
c151676
another failing sig test
bnewbold Mar 30, 2023
452ca53
better logging of signature validation errors
bnewbold Mar 30, 2023
df0352d
lexutil test: cleanup unimplemented nested IPLD CBOR part
bnewbold Mar 30, 2023
dfe912a
additional signature interop test
bnewbold Mar 31, 2023
876c961
better detection for which types need cbor marshalers
whyrusleeping Mar 31, 2023
ff7c60a
small fix to cborgen and some other cbor fixes
whyrusleeping Mar 31, 2023
8aca1df
testing: additional (failing) signature test
bnewbold Mar 31, 2023
f9d0d92
cleanups from lexgen changes, everything builds
bnewbold Mar 31, 2023
8d32a9d
cleanup test files
bnewbold Mar 31, 2023
e884b23
expand feedpost test to cover JSON output
bnewbold Mar 31, 2023
de73263
lexgen: more consistency between JSON and CBOR tags
bnewbold Mar 31, 2023
540d42c
lexgen: partial (manual) update of more omitempty, not clobbering be…
bnewbold Mar 31, 2023
13167ac
lexgen: do include all the other record-related updates
bnewbold Mar 31, 2023
2d41dab
cborgen
bnewbold Mar 31, 2023
812a34c
remove noisy debug println
bnewbold Mar 31, 2023
d0ea072
signature tests: remove skipped failing tests (sigs were bad), and ad…
bnewbold Apr 1, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions HACKING.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,11 @@ Other:
go run ./gen

To run codegen for new or updated Lexicons, using lexgen, first place (or git
checout) the JSON lexicon files `$SOMEWHERE`. Also, install the `goimports`
checout) the JSON lexicon files at `../atproto/`. Also, install the `goimports`
tool. Then, in *this* repository (indigo), run commands like:

go run ./cmd/lexgen/ --package bsky --prefix app.bsky --outdir api/bsky $SOMEWHERE/lexicons/app/bsky/
go run ./cmd/lexgen/ --package atproto --prefix com.atproto --outdir api/atproto $SOMEWHERE/lexicons/com/atproto/
go run ./cmd/lexgen/ --package bsky --prefix app.bsky --outdir api/bsky ../atproto/lexicons/app/bsky/
go run ./cmd/lexgen/ --package atproto --prefix com.atproto --outdir api/atproto ../atproto/lexicons/com/atproto/

You may want to delete all the codegen files before re-generating, to detect deleted files.

Expand All @@ -76,10 +76,8 @@ It can require some manual munging between the lexgen step and a later `go run .
To generate server stubs and handlers, push them in a temporary directory
first, then merge changes in to the actual PDS code:

go run ./cmd/lexgen/ --package pds --gen-server --types-import com.atproto:github.com/bluesky-social/indigo/api/atproto --types-import app.bsky:github.com/bluesky-social/indigo/api/bsky --outdir pds $SOMEWHERE/lexicons

mkdir tmppds
go run ./cmd/lexgen/ --package pds --gen-server --types-import com.atproto:github.com/bluesky-social/indigo/api/atproto --types-import app.bsky:github.com/bluesky-social/indigo/api/bsky --outdir tmppds --gen-handlers $SOMEWHERE/lexicons
go run ./cmd/lexgen/ --package pds --gen-server --types-import com.atproto:github.com/bluesky-social/indigo/api/atproto --types-import app.bsky:github.com/bluesky-social/indigo/api/bsky --outdir tmppds --gen-handlers ../atproto/lexicons


## tips and tricks
Expand Down
31 changes: 0 additions & 31 deletions api/atproto/accountcreateInviteCode.go

This file was deleted.

19 changes: 0 additions & 19 deletions api/atproto/accountget.go

This file was deleted.

19 changes: 0 additions & 19 deletions api/atproto/accountrequestDelete.go

This file was deleted.

25 changes: 0 additions & 25 deletions api/atproto/accountrequestPasswordReset.go

This file was deleted.

26 changes: 0 additions & 26 deletions api/atproto/accountresetPassword.go

This file was deleted.

76 changes: 0 additions & 76 deletions api/atproto/adminblob.go

This file was deleted.

Loading