Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identity: hack flag to skip handle resolution #854

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bnewbold
Copy link
Collaborator

Motivation here is to slash DNS lookups as part of cached DID resolution. As noted in the doc comment, we should loop back around and update the "Directory" interface/API to support this usecase better.

To actually deploy this in discover, we should:

  • confirm that we don't actually use handle resolution anywhere in discover. this will always return DID lookups with "invalid handle"
  • configure the redis directory "invalid handle TTL" to have the same duration as "hit" TTL
  • set this flag to "true" on the inner/wrapped base directory

This will only impact the "resolve identity by DID" path, not any "resolve identity by handle" paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant