:saprkles: Auto escalate accounts for high follow/like churn #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnewbold
reviewed
Sep 5, 2024
automod/engine/effects.go
Outdated
| @@ -128,6 +132,11 @@ func (e *Effects) TakedownAccount() { | |||
| e.AccountTakedown = true | |||
| } | |||
|
|
|||
| // Enqueues the entire account to be taken down at the end of rule processing. | |||
There was a problem hiding this comment.
comment out of date (copypasta)
automod/engine/metrics.go
Outdated
| @@ -40,6 +40,11 @@ var actionNewTakedownCount = promauto.NewCounterVec(prometheus.CounterOpts{ | |||
| Help: "Number of new flags persisted", | |||
| }, []string{"type"}) | |||
|
|
|||
| var actionNewEscalationCount = promauto.NewCounterVec(prometheus.CounterOpts{ | |||
| Name: "automod_new_action_escalations", | |||
| Help: "Number of new flags persisted", | |||
automod/engine/persist.go
Outdated
| @@ -57,8 +57,13 @@ func (eng *Engine) persistAccountModActions(c *AccountContext) error { | |||
| if err != nil { | |||
| return fmt.Errorf("circuit-breaking takedowns: %w", err) | |||
| } | |||
| // @TODO: do we want to check if the account is already escalated? | |||
There was a problem hiding this comment.
yeah, we should check here. we should also maybe popular review start as part of account meta? and clear account meta when it changes.
bnewbold
reviewed
Sep 6, 2024
automod/rules/interaction.go
Outdated
| @@ -25,6 +25,7 @@ func InteractionChurnRule(c *automod.RecordContext) error { | |||
| c.Logger.Info("high-like-churn", "created-today", created, "deleted-today", deleted) | |||
| c.AddAccountFlag("high-like-churn") | |||
| c.ReportAccount(automod.ReportReasonSpam, fmt.Sprintf("interaction churn: %d likes, %d unlikes today (so far)", created, deleted)) | |||
| c.EscalateAccount() | |||
There was a problem hiding this comment.
I'd be in favor of commenting this out for now, so we can review and get the engine change merged, then do the policy/behavior change separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.